[Bug 432259] Review Request: speech-dispatcher - Required for speech synthesis on OLPC XO

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: speech-dispatcher - Required for speech synthesis on OLPC XO


https://bugzilla.redhat.com/show_bug.cgi?id=432259


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|177841                      |
              nThis|                            |
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-06-20 11:51 EST -------
(In reply to comment #45)
For -12:

> >   - Also, change the permissions of the file in srpm (i.e. %SOURCEx)
> >     to 0644.
> 
> I have changed the permissions of the following files to 0644:
> 4] speech-dispatcherd (with execute capability however)

  Please also change this (speech-dispatcherd) to 0644 permission.
  You can safely do this because anyway you set the permission to
  0755 on installation:
-----------------------------------------------------------------------------
install -p -m 0755 %SOURCE1 $RPM_BUILD_ROOT%{_initrddir}/
-----------------------------------------------------------------------------
  (please fix this when you import this package to Fedora CVS)

 
> Yes, I am aware. I wrote two pre-reviews (#448458, #448292) 
  Well actually I reviewed bug 448292 (fbpanel) and your comment
  1 was very proper, however I didn't notice that _you_ wrote the comment
  :)

Okay.
----------------------------------------------------------------------------
          This package (speech-dispatcher) is APPROVED by me
----------------------------------------------------------------------------

Please follow the procedure written on:
http://fedoraproject.org/wiki/PackageMaintainers/Join

Now I am sponsoring you.

If you want to import this package into Fedora 8/9, you also have
to look at
http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT
(after once you rebuilt this package on koji Fedora rebuilding system).

If you have questions, please ask me.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.