[Bug 452455] Review Request: perl-DateTime-Locale - Localization support for DateTime.pm

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-DateTime-Locale - Localization support for DateTime.pm


https://bugzilla.redhat.com/show_bug.cgi?id=452455


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |ASSIGNED
               Flag|needinfo?(dev at nigelj.com)   |




------- Additional Comments From panemade at gmail.com  2008-06-23 01:36 EST -------
Review:
+ package builds in mock.
Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=675976
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
04cd7e65e4c773dfce972699aafc1f64  DateTime-Locale-0.4001.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test is ok.
All tests successful, 2 tests and 1 subtest skipped.
Files=10, Tests=9379,  4 wallclock secs ( 3.87 cusr +  0.13 csys =  4.00 CPU)

Except license everything else look ok to me. my question is can we see if CLDR
license can be approved license and can we specify it in License tag also?


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.