[Bug 451540] Review-Request: perl-String-Random - Perl module to generate random strings based on a pattern

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review-Request: perl-String-Random - Perl module to generate random strings based on a pattern


https://bugzilla.redhat.com/show_bug.cgi?id=451540


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2008-06-23 05:00 EST -------
Review:
+ package builds in mock.
Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=676061
+ rpmlint is silent for SRPM and for RPM.
+ source files match with different upstream url
c0319f95c56450624cc646f7425e327e  String-Random-0.22.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test
All tests successful.
Files=6, Tests=158,  0 wallclock secs ( 0.18 cusr +  0.03 csys =  0.21 CPU)
+ Package perl-String-Random-0.22-2.fc10 =>
Provides: perl(String::Random) = 0.22
Requires: perl >= 0:5.006_001 perl(:MODULE_COMPAT_5.10.0) perl(Carp)
perl(Exporter) perl(strict) perl(warnings)

SHOULD=>
   Change Source URL to
http://search.cpan.org/CPAN/authors/id/S/ST/STEVE/String-Random-0.22.tar.gz

APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.