[Bug 448025] Review Request: player - Cross-platform robot device interface and server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: player - Cross-platform robot device interface and server
Alias: player

https://bugzilla.redhat.com/show_bug.cgi?id=448025





------- Additional Comments From jspaleta at gmail.com  2008-06-23 13:24 EST -------
Okay first comments.

Builds against f9 and devel in mock.

Doesn't build against F8 in mock .. this isn't a blocker. But you should be
aware of this in case you want to open an F8 branch.  If you are planning on
opening an F8 branch we can look at this more closely after the review is done.


I think you should move the example code into an examples directory under 
/usr/share/ instead of leaving them under /usr/lib/. 
Either /usr/share/doc/player-examples by treating them as docs or under or
/usr/share/player/ by treating them as normal file payloads.  
There are existing examples of both types of behavior for examples subpackages.


I've run rpmlint against the f9 builds.. and for the most part no serious
problems.  But... the debuginfo package is throwing a lot of warnings and errors
from rpmlint concerning files in /usr/src/*  due to the fact that they are set
as executable in the orginal source tarball. I don't think its a serious issue,
but it might be easily fixable in the spec with a recursive chmod call to strip
the executable bits in the source subdirectories tree before the build. I'll
probably patch that into the spec file.

Working through the formal review now. I'll post a patched spec file as part of
the formal review.

-jef



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.