[Bug 448025] Review Request: player - Cross-platform robot device interface and server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: player - Cross-platform robot device interface and server
Alias: player

https://bugzilla.redhat.com/show_bug.cgi?id=448025





------- Additional Comments From jspaleta at gmail.com  2008-06-23 20:33 EST -------
rpmlint output with specfile modified to silence the debuginfo rpmlint warnings.
See attached attachment for updated specfile.

I'm not sure what to do about the examples subpackage.  It contains source code,
libraries and executables..all of which is put under _libdir/player/examples/

I'm not sure that is appropriate. It feels a little wonky to do it that way.
If the point of the examples are coding examples for review...I would almost
prefer that the examples were not compiled and that the examples subpackage only
included the source material and instructions on how to compile the examples on
a client system as needed.  

Anyways here's the rpmlint output. I'm fine with everything except the examples
warnings and docs subpackage errors. I'll need to look at the docs errors a bit
more.  Do those mentioned zero-length map files need to be included at all?


player-devel.i386: W: no-documentation

player-doc.i386: E: zero-length
/usr/share/doc/player-doc-2.1.0/player-docs/classClaser__coll__graph.map
player-doc.i386: E: zero-length
/usr/share/doc/player-doc-2.1.0/player-docs/classMessageReplaceRule__coll__graph.map
player-doc.i386: E: zero-length
/usr/share/doc/player-doc-2.1.0/player-docs/classConfigFile__coll__graph.map

player-examples.i386: W: no-documentation
player-examples.i386: W: devel-file-in-non-devel-package
/usr/lib/player/examples/libplayerc++/args.h
player-examples.i386: W: devel-file-in-non-devel-package
/usr/lib/player/examples/plugins/exampleinterface/example_xdr.h
player-examples.i386: W: devel-file-in-non-devel-package
/usr/lib/player/examples/plugins/exampledriver/libexampledriver.a
player-examples.i386: W: devel-file-in-non-devel-package
/usr/lib/player/examples/plugins/multidriver/libmultidriver.a
player-examples.i386: W: devel-file-in-non-devel-package
/usr/lib/player/examples/plugins/opaquedriver/libopaquedriver.a
player-examples.i386: W: devel-file-in-non-devel-package
/usr/lib/player/examples/plugins/exampleinterface/example_functiontable.c
player-examples.i386: W: devel-file-in-non-devel-package
/usr/lib/player/examples/plugins/exampleinterface/libeginterf.a
player-examples.i386: W: devel-file-in-non-devel-package
/usr/lib/player/examples/plugins/exampleinterface/eginterf_client.c
player-examples.i386: W: devel-file-in-non-devel-package
/usr/lib/player/examples/plugins/logplugin/liblogplugin.a
player-examples.i386: W: devel-file-in-non-devel-package
/usr/lib/player/examples/plugins/exampleinterface/libeginterfdriver.a
player-examples.i386: W: devel-file-in-non-devel-package
/usr/lib/player/examples/plugins/exampleinterface/example_interface.h
player-examples.i386: W: devel-file-in-non-devel-package
/usr/lib/player/examples/libplayerc/speech_c_client.c
player-examples.i386: W: devel-file-in-non-devel-package
/usr/lib/player/examples/libplayerc/simple.c
player-examples.i386: W: devel-file-in-non-devel-package
/usr/lib/player/examples/libplayerc/service_discovery.c
player-examples.i386: W: devel-file-in-non-devel-package
/usr/lib/player/examples/libplayerc/vmap.c

player-python.i386: W: no-documentation
player-python.i386: E: non-standard-executable-perm
/usr/lib/python2.5/site-packages/_playerc.so 0775

player-static.i386: W: no-documentation
8 packages and 0 specfiles checked; 4 errors, 19 warnings.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.