[Bug 449135] Review Request: gforge - GForge Collaborative Development Environment

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gforge - GForge Collaborative Development Environment


https://bugzilla.redhat.com/show_bug.cgi?id=449135





------- Additional Comments From musuruan at gmail.com  2008-06-25 05:29 EST -------
(In reply to comment #4)
> And regarding the non-fedora bits, I might remove the check for build root not
> being root directory, but the cleaning of buildroot _is_ a fedora bit.

Cleaning the buildroot this way:
[ "$RPM_BUILD_ROOT" != "/" ] && rm -rf $RPM_BUILD_ROOT
is not a Fedora bit.

Since you should NEVER build an RPM as root, it MUST be done this way:
rm -rf $RPM_BUILD_ROOT

> Regarding the version, I have upgraded (and uploaded) the package to the latest
> stable version (4.5.19)

At each update, you must provide a link to the updated spec file and a link to
the new source RPM file and a changelog. This is a Fedora Packaging guideline.

Moreover, you aren't versioning the spec file in the changelog (something
rpmlint complains about) and you didn't update the changelog.

The licence tag in not correct. GPL is not an acceptable license (but, for
example, GPLv2 is). This is also something rpmlint complains about.

Since you are looking for a sponsor, I suggest you to read this:
http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.