[Bug 446102] Review Request: xdialog - X11 drop in replacement for cdialog

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xdialog -  X11 drop in replacement for cdialog


https://bugzilla.redhat.com/show_bug.cgi?id=446102


mnowak at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mnowak at redhat.com




------- Additional Comments From mnowak at redhat.com  2008-06-25 13:27 EST -------
Informal package review:
========================


-Release: 1%{dist}
-License: GPL+
+Release: 1%{?dist}
+License: GPLv2

* The preferred dist tag is now ?dist.
* License should be as concrete as possible, in source archive is GPLv2

-URL: http://xdialog.dyns.net/
+URL: http://xdialog.free.fr

* This is the server, where sources are located.

-BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root
+BuildRoot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)

* Tip: this is #1 in "BuildRoot tag" section of
https://fedoraproject.org/wiki/Packaging/Guidelines
 
 BuildRequires: gtk+-devel >= 1.2.0

* Isn't it possible to completely get rid of GTK+v1? It's ugly, not widely
supported these days and adds build dependency.
 
-%{__rm} -rf %{buildroot}
+rm -rf %{buildroot}

* Be consistent, use command style OR macro style.
 
-%{__rm} -rf %{buildroot}
+rm -rf %{buildroot}

* Same ^ here.
 
-%defattr(-, root, root, 0755)
-%doc AUTHORS BUGS ChangeLog COPYING NEWS README
+%defattr(-, root, root, -)
+%doc AUTHORS BUGS ChangeLog COPYING 

* IMO, useless for docs.
* README is not maintained for years (just read it) and NEWS is symlink to
ChangeLog.

-%{_mandir}/man1/Xdialog.1*
+%{_mandir}/man?/%{real_name}*

* This is more general way how to play with man pages, don't have to care of
every one page and of the section. 

-* Sat Apr  5 2008 Patrice Dumas <pertusus at free.fr> 2.3.1-1
-- submit to fedora.
+* Sat Apr  5 2008 Patrice Dumas <pertusus at free.fr> - 2.3.1-1
+- Submit to Fedora.
 
* Just some more consistency issues.
--

Please see the output of rpmlint on arch dependent package (e.g. i386) you'll
see lot of warning about +x on doc files:

   xdialog.i386: W: spurious-executable-perm
/usr/share/doc/xdialog-2.3.1/samples/timebox

* Change it to 0644 or erase them.
--
Hope it's useful.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.