[Bug 436147] Review Request: mairix - A program for indexing and searching email messages

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mairix - A program for indexing and searching email messages


https://bugzilla.redhat.com/show_bug.cgi?id=436147


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2008-06-25 23:12 EST -------
I'm not really sure why this has been sitting around for so long; it's a small
package, it builds fine and rpmlint finds nothing to complain about.  I can't
really test it because all of my mail is locked away in a cyrus server, but I
can review the packaging.

Everything looks fine to me.

* source files match upstream:
   e1d28459531ce30ce8dd41215cb0e6351ea81767cf4bbf1e8dbd22618f4de1d7  
   mairix-0.21.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
* rpmlint is silent.
* final provides and requires are sane:
   mairix = 0.21-1.fc10
  =
   libbz2.so.1()(64bit)
   libz.so.1()(64bit)

* %check is not present; no test suite upstream.  I do not have the means to 
   test this package.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.