[Bug 449135] Review Request: gforge - GForge Collaborative Development Environment

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gforge - GForge Collaborative Development Environment


https://bugzilla.redhat.com/show_bug.cgi?id=449135





------- Additional Comments From javiplx at gmail.com  2008-06-26 15:07 EST -------
First of all, I've discovered the rpmlint discrepancies. I was running that on
the specfile itself, but not on the packages. It looks like rpmlint reads the
RPM headers, so I didn't discovered many things (as far as I know, the
non-standard-uid for apache are not important, are they?)

The new versions are on
Spec URL: http://www.freewebs.com/javiplx/Fedora/gforge.spec
SRPM URL: http://www.freewebs.com/javiplx/Fedora/gforge-4.5.19-2.fc9.src.rpm

Buildroot, %_sysconfigdir, and %docs fixed.

For Changelod I preferred the third available option, as I tend to copy the
modifier line and change only the date.

I've changed also the license, but I have a doubt about it. The upstream site
(fixed now on URL) simply states 'GPL'. Shouldn't this be honoured ?

Regarding the Source with full url, the download url
(http://gforge.org/frs/download.php/245/gforge-4.5.19.tar.bz2) includes a
internal release number 245 that changes from one version to another on
unrelated manner (for 4.4 is 102). Is it OK to use this unpredictable value ?

mailman requirement is also fixed. It was actually a mistake.

Regarding subpackages (specifically svn/cvs) I'm still believe the package is
not mature enough. The packaged local.inc fixes sys_use_scm=false, so none of
them are currently a requirement. I obviously plan to make them available, but I
need more work to make that smoothly. Currently I use gforge at workplace, but
without many features (not only SCM but also mailmain) and it's perfectly
functional, even whithout the many subdirs I opted not to copy to buildroot.

My plans, in parallel with made the package compliant with guidelines, is to
enable all this stuff one by one with proper although basic testing, to ensure
that the final package is at least only partly broken. As example, adding the
plugins directory adds some Perl requirements on a full PHP package that I think
must be tracked.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.