[Bug 445652] Review Request: libloader - Java Resource Loading Framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libloader - Java Resource Loading Framework


https://bugzilla.redhat.com/show_bug.cgi?id=445652


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2008-06-27 16:37 EST -------
Builds fine; rpmlint just says:
  libloader-javadoc.x86_64: W: non-standard-group Development/Documentation
which isn't a problem since we don't care about Group: anyway.

I can't seem to find anything related to this package at the upstream URL given.
 Am I missing something?

I'm no java expert so I'm just relying on the guidelines; they indicate that you
should be able to call ant with just "ant" instead of "ant compile javadoc" and
indeed the packages seem to come out the same.  I don't think this is remotely
significant, though.

I don't see anything which would prevent this package from being approved, though.

* source files match upstream:
   2ba6b426309d150e897731942aadf464f91adc3617a36744bce7a5bbeb62de9f  
  libloader-0.3.7.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
* rpmlint has acceptable complaints.
* final provides and requires are sane:
  libloader-0.3.7-1.fc10.x86_64.rpm
   libloader.jar.so()(64bit)
   libloader = 0.3.7-1.fc10
  =
   /bin/sh
   java
   java-gcj-compat >= 1.0.31
   jcommon
   jpackage-utils
   libgcc_s.so.1()(64bit)
   libgcc_s.so.1(GCC_3.0)(64bit)
   libgcj_bc.so.1()(64bit)
   libz.so.1()(64bit)

  libloader-javadoc-0.3.7-1.fc10.x86_64.rpm
   libloader-javadoc = 0.3.7-1.fc10
  =
   jpackage-utils
   libloader = 0.3.7-1.fc10

* %check is not present; no test suite upstream.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* code, not content.
* %docs are not necessary for the proper functioning of the package.
Java-specific bits:
* no pre-built jars
* single jar, named after the package
* jarfiles are under _javadir.
* javadocs are under _javadocdir.
* ant called properly.
* no wrapper script necessary.
* gcj called properly.
* gcj scriptlets present and OK.
 
APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.