[Bug 452636] Review Request:http-mod_proxy_html - Module to rewrite content as it passes through an apache proxy.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request:http-mod_proxy_html - Module to rewrite content as it passes through an apache proxy.


https://bugzilla.redhat.com/show_bug.cgi?id=452636





------- Additional Comments From philipp at redfish-solutions.com  2008-06-28 14:13 EST -------
I have no problem merging them.  That's fine.

Some observations:

* we don't need -Wl,"-lxml2" in the invocation of apxs.  We can just use -lxml2 
directly;

* similarly, it would be preferable to install via "apxs -i -S 
LIBEXECDIR=$RPM_BUILD_ROOT/%{modulesdir} -n %{modname} %{modname}.la" as I've 
done; the .libs directory is an implementation detail of apxs using libtool 
that we shouldn't rely on;

Do we really need to supply the path to apxs?  It should be in the default 
search path.  If it's not, it might be because someone wants to try out a new 
version of it (in which case we should use that anyway).

Other than that, I'm fine with the rest of the changes.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.