[Bug 450686] Review Request: R-RSQLite - SQLite Interface for R

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: R-RSQLite - SQLite Interface for R


https://bugzilla.redhat.com/show_bug.cgi?id=450686


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+

Bug 450686 depends on bug 450685, which changed state.

Bug 450685 Summary: Review Request: R-DBI - Database Interface for R
https://bugzilla.redhat.com/show_bug.cgi?id=450685

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |CURRENTRELEASE



------- Additional Comments From tibbs at math.uh.edu  2008-06-29 13:14 EST -------
I'd suggest using http://cran.r-project.org/web/packages/RSQLite/index.html for
the URL, as it actually has some information about the package.

* source files match upstream:
   8eb6faf25b494db17c74e0a83099839796539ae059cc8fd58fbac13aac2c63d8  
   RSQLite_0.6-9.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
* rpmlint has acceptable complaints.
* final provides and requires are sane:
   RSQLite.so()(64bit)
   R-RSQLite = 0.6-3.fc10
  =
   /bin/bash
   /bin/sh
   R
   R-DBI
   libR.so()(64bit)

* %check is present and all tests pass.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets OK (R package registration)
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.