[Bug 227116] Review Request: servletapi4-4.0.4-4jpp - Java servlet and JSP implementation classes

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: servletapi4-4.0.4-4jpp - Java servlet and JSP implementation classes


https://bugzilla.redhat.com/show_bug.cgi?id=227116





------- Additional Comments From jochen at herr-schmitt.de  2008-06-29 15:02 EST -------
Good:
+ Local build works fine.
+ Mock build works fine.

Bad:

- Rpmlint complaints source rpm:
$ rpmlint servletapi4-4.0.4-4jpp.src.rpm
servletapi4.src:50: W: unversioned-explicit-provides servlet
servletapi4.src:57: W: unversioned-explicit-obsoletes servlet4
servletapi4.src:58: W: unversioned-explicit-obsoletes servlet23
servletapi4.src:59: W: unversioned-explicit-provides servlet4
servletapi4.src:60: W: unversioned-explicit-provides servlet23
servletapi4.src:74: W: rpm-buildroot-usage %prep rm -rf $RPM_BUILD_ROOT
servletapi4.src:75: W: setup-not-quiet
servletapi4.src:173: W: macro-in-%changelog name
servletapi4.src: E: no-cleaning-of-buildroot %install
servletapi4.src: W: mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 31)
servletapi4.src: W: non-standard-group Internet/WWW/Dynamic Content
servletapi4.src: W: invalid-license Apache License
servletapi4.src: E: unknown-key GPG#c431416d
1 packages and 0 specfiles checked; 2 errors, 11 warnings.
- Package contains wrong Group tag
- Package should not contains Vendor tag
- Package should not contains Distribution tag.
- Source tag contains not a full quallified URI
- Package doesn't contains buildRequires and Requires to java
- Rpmlint conplaints binary package:
$ rpmlint servletapi4-4.0.4-4jpp.noarch.rpm
servletapi4.noarch: W: non-standard-group Internet/WWW/Dynamic Content
servletapi4.noarch: W: incoherent-version-in-changelog 4.0.4-4jpp 0:4.0.4-4jpp
servletapi4.noarch: W: invalid-license Apache License
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
- Rpmlint complaints javadoc rpm:
$ rpmlint servletapi4-javadoc-4.0.4-4jpp.noarch.rpm
servletapi4-javadoc.noarch: W: non-standard-group Development/Documentation
servletapi4-javadoc.noarch: W: invalid-license Apache License
1 packages and 0 specfiles checked; 0 errors, 2 warnings.



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.