[Bug 453422] Review Request: songbird - Mozilla based multimedia player

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: songbird - Mozilla based multimedia player


https://bugzilla.redhat.com/show_bug.cgi?id=453422





------- Additional Comments From auralvance at gmail.com  2008-06-30 14:12 EST -------
To clarify on the x86_64 debug comment in the spec file: /usr/lib/rpm/debugedit
is called during the debug creation process and it fails to read the x86_64
binaries.

extracting debug info from
/var/tmp/songbird-0.6.1-1-root-mockbuild/usr/lib64/songbird-0.6.1/xulrunner/xulrunner-bin
Failed to write file: invalid section entry size

This is not an issue in i386. I verified that the packages still work as
intended, but the debug info is somehow maligned. This issue is definitely
upstream, so I will be posting a bug when I have one. For more info I found the
same issue in bug 187243

As for rpmlint, there are some issues, but all are upstream:

$ rpmlint /usr/src/redhat/RPMS/i386/songbird-0.6.1-1.fc9.i386.rpm 
songbird.i386: E: script-without-shebang
/usr/lib/songbird-0.6.1/xulrunner/README.txt
songbird.i386: E: script-without-shebang
/usr/lib/songbird-0.6.1/xulrunner/icons/mozicon16.xpm
songbird.i386: E: script-without-shebang
/usr/lib/songbird-0.6.1/searchplugins/google-lyrics.xml
songbird.i386: W: wrong-file-end-of-line-encoding
/usr/share/doc/songbird-0.6.1/README.txt
songbird.i386: E: script-without-shebang
/usr/lib/songbird-0.6.1/xulrunner/icons/mozicon50.xpm
songbird.i386: W: hidden-file-or-dir /usr/lib/songbird-0.6.1/.autoreg
songbird.i386: E: zero-length /usr/lib/songbird-0.6.1/.autoreg
songbird.i386: E: script-without-shebang
/usr/lib/songbird-0.6.1/xulrunner/components/nsContentPrefService.js
songbird.i386: W: file-not-utf8 /usr/share/doc/songbird-0.6.1/TRADEMARK.txt
songbird.i386: E: script-without-shebang
/usr/lib/songbird-0.6.1/components/sbAddonMetadata.js
songbird.i386: E: script-without-shebang
/usr/lib/songbird-0.6.1/xulrunner/components/nsHandlerService.js
songbird.i386: E: script-without-shebang /usr/lib/songbird-0.6.1/xulrunner/LICENSE
songbird.i386: E: binary-or-shlib-defines-rpath
/usr/lib/songbird-0.6.1/components/sbMetadataHandlerTaglib.so
['$ORIGIN/../xulrunner']
songbird.i386: W: no-soname /usr/lib/songbird-0.6.1/lib/sbGStreamer.so
songbird.i386: E: binary-or-shlib-defines-rpath
/usr/lib/songbird-0.6.1/xulrunner/mangle ['$ORIGIN/../lib']
songbird.i386: E: binary-or-shlib-defines-rpath
/usr/lib/songbird-0.6.1/xulrunner/shlibsign ['$ORIGIN/../lib']
1 packages and 0 specfiles checked; 12 errors, 4 warnings.

The only one I was really concerned with is the RPATH error, but this seems to
be completely internal in order to direct songbird to its own xulrunner libs. If
it were to ask LD for information I'm guessing songbird would receive local
xulrunner libs which are not patched by upstream.

Feedback is appreciated.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.