[Bug 446134] Review Request: jsr-305 - reference implementation of JSR-305

bugzilla at redhat.com bugzilla at redhat.com
Mon Jun 30 21:06:13 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: jsr-305 - reference implementation of JSR-305


https://bugzilla.redhat.com/show_bug.cgi?id=446134





------- Additional Comments From loganjerry at gmail.com  2008-06-30 17:06 EST -------
Thanks once again for doing a review for me, Jason.

This package defines some annotations that Java programmers use to declare
various properties of their code.  Those annotations are consumed by the
findbugs tool, which I will be submitting to Fedora Real Soon Now.

I fixed the broken URLs and dropped the index.html file.  Incidentally, upstream
has promised to include a LICENSE file at some point; see
http://groups.google.com/group/jsr-305/msg/e6d62dc6cd7fe361.  This is noted in
the spec file.

I have included subversion checkout instructions, and have versioned the
tarball.  I have made the package own what it puts into /etc/maven/fragments and
/usr/share/maven2/poms instead of owning the directories.  As far as I know, the
question about versioned symlinks for javadocs is still unresolved, so I left
that bit alone.  I have conditionalized the GCJ bits.

Some source files do not appear in the debuginfo package because they contain no
code.  Those files contain only annotation definitions.  This is why I dropped
the GCJ bits from the jcip-annotations package altogether, because GCJ produces
nothing useful from annotation definition only files.  There are some files with
code in this package, though, so I left the GCJ bits in; those files show up in
the debuginfo package.

New versions of the spec file and SRPM are here:
http://jjames.fedorapeople.org/jsr-305/jsr-305.spec
http://jjames.fedorapeople.org/jsr-305/jsr-305-0-0.1.20080613svn.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list