[Bug 431188] Review Request: minbar - Athan call and prayer times notification software

bugzilla at redhat.com bugzilla at redhat.com
Sun Mar 2 16:27:27 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: minbar - Athan call and prayer times notification software


https://bugzilla.redhat.com/show_bug.cgi?id=431188


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-03-02 11:27 EST -------
For 0.2.1-5:

* GConf scriptlet
  - I didn't notice before, but "Requires(pre): GConf" is
    missing.

* sed usage
------------------------------------------------------------
sed -i "s|\(Utility;)\1|\1|" %{name}.desktop.in
------------------------------------------------------------
  - The correct one is:
------------------------------------------------------------
sed -i "s|\(Utility;\)\1|\1|" %{name}.desktop.in
------------------------------------------------------------

Other things are okay.
--------------------------------------------------------------------------
         This package (minbar) is APPROVED by me.
--------------------------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list