[Bug 435064] Review Request: midisport-firmware - firmware files for M-Audio/Midiman USB MIDI and Audio devices

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: midisport-firmware - firmware files for M-Audio/Midiman USB MIDI and Audio devices


https://bugzilla.redhat.com/show_bug.cgi?id=435064





------- Additional Comments From lkundrak at redhat.com  2008-03-03 14:20 EST -------
Something from rpmlint:

midisport-firmware.noarch: E: description-line-too-long This package contains
the firmware for M-Audio/Midiman USB MIDI and Audio devices
Your description lines must not exceed 79 characters. If a line is exceeding
this number, cut it to fit in two lines.

midisport-firmware.noarch: W: non-conffile-in-etc
/etc/udev/rules.d/81-midisport.rules
A non-executable file in your package is being installed in /etc, but is not
a configuration file. All non-executable files in /etc should be configuration
files. Mark the file as %config in the spec file.

Please mark the udev rules file as %config. rpmlint will probably complain that
it's not %config(noreplace). That's fine, ignore it.

And some more issues:

 32 install -pm 0644 81-midisport.rules $RPM_BUILD_ROOT/etc/udev/rules.d/

Replace 81-midisport.rules with %{SOURCE1}
Create the directory $RPM_BUILD_ROOT%{_sysconfdir}/udev/rules.d/ prior to
copying to it.

That should be all.



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.