[Bug 398111] Review Request: xfce4-time-out-plugin - Xfce panel plugin for taking breaks from the computer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xfce4-time-out-plugin - Xfce panel plugin for taking breaks from the computer


https://bugzilla.redhat.com/show_bug.cgi?id=398111


kevin at tummy.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From kevin at tummy.com  2008-03-05 21:22 EST -------

OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (GPLv2+)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
d2f5b157cf47c754d8dd007c73a4d1e6  xfce4-time-out-plugin-0.1.1.tar.bz2
d2f5b157cf47c754d8dd007c73a4d1e6  xfce4-time-out-plugin-0.1.1.tar.bz2.spec
See below - BuildRequires correct
OK - Spec handles locales/find_lang
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - No rpmlint output.
OK - final provides and requires are sane

SHOULD Items:

OK - Should build in mock.
OK - Should build on all supported archs
OK - Should function as described.
OK - Should have dist tag
OK - Should package latest version

Issues:

1. I see:
checking for IceConnectionNumber in -lICE...
no

In the build log. Should this BuildRequire: libICE-devel ?
Or is this a cosmetic test thats not really needed here?

That's the only (very minor) issue I find here...
If you could check on that requirement before checking in that
would be great. This package is APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.