[Bug 433187] Review Request: boinc-client - A platform for distributed computing

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: boinc-client - A platform for distributed computing
Alias: boinc-client-review

https://bugzilla.redhat.com/show_bug.cgi?id=433187





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-03-06 13:02 EST -------
Well, for 5.10.40-6:

* %pre script
------------------------------------------------------
[ -x /etc/init.d/boinc-client ] && /sbin/service boinc-client stop
------------------------------------------------------
  - This line is not needed, and actually this is problematic
    because with this script boinc-client stops every time
    boinc-client is upgraded.

* /sbin/ldconfig
------------------------------------------------------
%post devel -p /sbin/ldconfig
%postun devel -p /sbin/ldconfig
------------------------------------------------------
  - These are not needed

* Macros usage
  - Please unify macros usage. For example:
------------------------------------------------------
mv $RPM_BUILD_ROOT%{_bindir}/ca-bundle.crt \
  $RPM_BUILD_ROOT%{_localstatedir}/lib/boinc
.......           ^^^^^^^^^^^^^^^^^
/sbin/restorecon /var/lib/boinc/error.log
                ^^^^^^^
------------------------------------------------------

* Directory ownership issue
  - %_localstatedir/lib/boinc is not owned by any package.

* Dependency for -devel subpackage
  - Please check the dependency for -devel package.
    For example, %_includedir/BOINC/crypt.h contains:
------------------------------------------------------
    28  #if !(defined(USE_OPENSSL) || defined(USE_RSAEURO))
    29  #define USE_OPENSSL 1
    30  //#define USE_RSAEURO 1
    31  #endif
    43  #ifdef USE_OPENSSL
    44  #include <openssl/rsa.h>
------------------------------------------------------
    This means -devel subpackage should have:
    "Requires: openssl-devel" (here I am not mentioning about
     BuildRequires).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.