[Bug 435125] Review Request: xerces-c27 - Compatibility package for Xerces C++ 2.7.0

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xerces-c27 - Compatibility package for Xerces C++ 2.7.0


https://bugzilla.redhat.com/show_bug.cgi?id=435125


tcallawa at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tcallawa at redhat.com
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+




------- Additional Comments From tcallawa at redhat.com  2008-03-07 16:06 EST -------
Review
=======

Good:

- rpmlint checks return:
xerces-c27-devel.x86_64: W: no-documentation
xerces-c27-devel.x86_64: W: dangling-relative-symlink
/usr/lib64/xerces-c-2.7.0/libxerces-c.so ../libxerces-c.so.27
xerces-c27-devel.x86_64: W: dangling-relative-symlink
/usr/lib64/xerces-c-2.7.0/libxerces-depdom.so ../libxerces-depdom.so.27
xerces-c27-devel.x86_64: E: only-non-binary-in-usr-lib

All are safe to ignore.

- package meets naming guidelines
- package meets packaging guidelines
- license (ASL 2.0) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- doc subpackage OK
- nothing in %doc affects runtime
- no need for .desktop file
- devel subpackage OK, depends on base package

Approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.