[Bug 225243] Merge Review: amanda

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: amanda


https://bugzilla.redhat.com/show_bug.cgi?id=225243





------- Additional Comments From orion at cora.nwra.com  2008-03-12 00:47 EST -------
(In reply to comment #3)
> I'm slightly missing what are our roles here, but thanks :-)

Basically, with the merge of core and extras, all core packages were set to go
through a package review to make sure they conformed to modern Fedora packaging
guidelines.  As a Fedora packager, I'm here to help with that, and I assume you
are the current amanda maintainer. :-)

> About your changes:
> 
> The PIE patch is apparently still needed, as the build fails with your spec:
> 
> /usr/bin/ld: .libs/alloc.o: relocation R_X86_64_PC32 against `debug_alloc' can
> not be used when making a shared object; recompile with -fPIC
> /usr/bin/ld: final link failed: Bad value
> 
> That means, -PIE option can only be used for executables, not libraries, so
> adding -fPIE/-pie to common *FLAGS cannot work. And thus the autotools will be
> still needed.

Ah well.  I've updated the pie patch then.  What does -pie buy us these days? 
Doesn't seem like many programs use it.
 
> As for the username changing, it's needed when upgrading from older packages and
> the %post is not for server subpackage, but for main amanda package (or say,
> common), where the .amandahosts file is contained.

The problem is that the username listed in .amandahosts is the username on the
remote machine, not the named on the machine .amandahosts resides on.  We don't
know that the remote machine has been upgraded or not.  Either way can cause
problems though, so it's up to you.

> Rest seems ok, but I'll rather wait with the updgrade at least for final release
> of Amanda 2.6.0, they are still doing changes...

That's fine.  Too bad we missed the freeze, but ah well.

http://www.cora.nwra.com/~orion/fedora/amanda-2.6.0-0.b3_20080310.fc8.src.rpm

* Tue Mar 11 2008 Orion Poplawski <orion at cora.nwra.com> 2.6.0-0.b3_20080310.1
- Update to 2.6.0b3_20080310
- Re-add updated pie patch, re-add autogen
- Update example patch to modify Makefile.am, leave template.d in
 /var/lib/amanda for now

TODO:

- Update xinetd and default .amandahosts files
- More rpmlint cleanups
- learn more about template.d

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.