[Bug 436619] Review Request: bibus - Bibliographic and reference management software

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bibus - Bibliographic and reference management software


https://bugzilla.redhat.com/show_bug.cgi?id=436619


pingoufc4 at yahoo.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From pingoufc4 at yahoo.fr  2008-03-13 09:46 EST -------
MUST
=>rpmlint 
bibus.noarch: W: symlink-should-be-relative /usr/bin/bibus
/usr/share/bibus/bibusStart.py
* Name OK 
* Spec name OK
=> Package Guidelines: NOTOK
The desktop-file-install according to 
http://fedoraproject.org/wiki/Packaging/Guidelines#head-d559ee7363418a5840ce63090c608c991cd39ce6
If upstream uses <vendor_id>, leave it intact, otherwise use fedora as <vendor_id>. 
* License OK
* Doc OK
* English OK
* Sources OK:
22b91fb9daf1e002e521e6315ade7b28  Desktop/bibus_1.4.1-1.tar.gz
22b91fb9daf1e002e521e6315ade7b28  rpmbuild/SOURCES/bibus_1.4.1-1.tar.gz
* Build OK on Fedora 8 x64_86 and Fedora 8 i386 (rpmbuild and mock for both arch)
* Installs and works OK
* Local properly handle OK
* Directory OK
* %file duplicate -> none OK
* Permission OK
* Clean section OK
=> MUST: Packages containing GUI applications must include a %{name}.desktop NOTOK
=> MUST: Packages must not own files or directories already owned by other
packages.NOTOK
%{_datadir}/applications/*
%{_datadir}/icons/hicolor/48x48/apps/*
%{_mandir}/man1/*
Should be changed to 
%{_datadir}/applications/%{name}.desktop
%{_datadir}/icons/hicolor/48x48/apps/%{name}.png
%{_mandir}/man1/%{name}.1.gz
*UTF-8 OK

Few questions on the file management else it looks ok :)
If you can get those changes to upstream this will definitively be easier to
maintain.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.