[Bug 435842] Review Request: viewmtn - Web interface for Monotone version control system

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: viewmtn - Web interface for Monotone version control system


https://bugzilla.redhat.com/show_bug.cgi?id=435842





------- Additional Comments From thomas.moschny at gmx.de  2008-03-14 05:16 EST -------
(In reply to comment #2)
> - I would have thought that too, but I'm following the example of mailman
> mm_cfg.py, which is just the same sort of case.

The mailman package doing it this way doesn't mean it's correct or even useful 
here. 

With the current setup, ViewMTN doesn't care at all about a config file 
in /etc, so why should the symlink be there at all? Solely as a hint, where to 
look for the real config file? I don't think so.

So, inverting the symlink direction is in fact not enough, but additionally, 
your sniplet added at the end of config.py, should import the file from /etc 
and not from %{python_sitelib}/viewmtn.

Again, I consider it a packaging bug if a file under /usr has to be edited in 
order to configure the package, at least I understand the FHS this way. 
Additionally, because %{python_sitelib}/viewmtn/user_config.py is not 
marked %config, changes made there are easily overwritten during a package 
update.

> - monotone's poor support for db file sharing makes it extremely hairy to
> make anything work out of the box.  The sample configuration in the
> viewmtn rpm works for ssh-based db serving as deployed on fedorahosted.org
> now.  I want to get viewmtn packaged and running before we try to solve
> every problem.

It didn't affect usage on fedorahosted.org, if, in addition 
to /srv/mtn/*/db.mtn, /var/lib/monotone/server.mtn, would be considered for 
the list of dbs to be served, does it? Thought ViewMTN tried to work around 
the sharing problems (in a limited fashion) by restarting the mtn process in 
case of any problem. Otoh, this is not a blocker issue.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.