[Bug 435155] Review Request: fuse-s3fs - Fuse filesystem for amazon.com's S3 storage service

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fuse-s3fs - Fuse filesystem for amazon.com's S3 storage service


https://bugzilla.redhat.com/show_bug.cgi?id=435155





------- Additional Comments From kevin at tummy.com  2008-03-15 12:42 EST -------

OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (GPLv2)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
See below - Sources match upstream md5sum:
See below - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
See below - No rpmlint output.
OK - final provides and requires are sane.

SHOULD Items:

OK - Should build in mock.
OK - Should build on all supported archs
OK - Should function as described.
OK - Should have dist tag
OK - Should package latest version

Issues:

1. Your sources don't match with upstream:
d5904f2d8feae8c1e946b5cc3f4af82e  fuse-s3fs-0.4.tbz2
0821843e99f686a2854b2b12b3c5b06a  fuse-s3fs-0.4.tbz2.orig

I am looking at the src.rpm from comment #19.
Have you changed the upstream source since then without changing
the release?

2. rpmlint says:

fuse-s3fs.src: W: strange-permission fuse-s3fs.spec 0600

Can you make the spec mode 644 or the like?

3. Do you really need
BuildRequires: python ?
Nothing in the build seems to be needing python that I can see.

4. Might use '-p' with your install lines to preserve the timestamps
from the upstream package on install.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.