[Bug 427674] Review Request: themonospot -application that can be used to scan an avi file and extract some informations about audio and video data flow

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: themonospot -application that can be used to scan an avi file and extract some informations about audio and video data flow


https://bugzilla.redhat.com/show_bug.cgi?id=427674





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-03-15 13:24 EST -------
For 0.6.5-8:

* Source
  - Source tag must point to the URL from which we can actually
    receive the source used in the srpm by "wget -N", for example.

    When I try to download the source from the URL written as Source
    by wget -N, 
-------------------------------------------------------------------
$ LANG=C wget -N
http://www.integrazioneweb.com/themonospot/packages/fedora/themonospot-0.6.5.tar.gz
--01:11:59-- 
http://www.integrazioneweb.com/themonospot/packages/fedora/themonospot-0.6.5.tar.gz
           => `themonospot-0.6.5.tar.gz'
Resolving www.integrazioneweb.com... 151.13.66.154, 83.103.22.154
Connecting to www.integrazioneweb.com|151.13.66.154|:80... connected.
HTTP request sent, awaiting response... 301 Moved Permanently
Location:
http://www.integrazioneweb.com/themonospot/packages/fedora/themonospot%2D0.6.5.tar.gz/
[following]
--01:12:01-- 
http://www.integrazioneweb.com/themonospot/packages/fedora/themonospot%2D0.6.5.tar.gz/
           => `index.html'
Reusing existing connection to www.integrazioneweb.com:80.
HTTP request sent, awaiting response... 200 OK
Length: 139,900 (137K) [application/octet-stream]

100%[===================================================================>]
139,900       76.78K/s             

Last-modified header missing -- time-stamps turned off.
01:12:03 (76.63 KB/s) - `index.html' saved [139900/139900]
-------------------------------------------------------------------
     Why is the file downloaded named as index.html?

  - Also,
-------------------------------------------------------------------
131143 2008-01-18 18:06 themonospot-0.6.5-7/themonospot-0.6.5.tar.gz
139900 2008-03-13 18:00 themonospot-0.6.5-8/themonospot-0.6.5.tar.gz
-------------------------------------------------------------------
    the source changed.
    - You should not change the source tarball without changing version
      once it is published formally because this causes confusion for
      people using the tarball.
    - Or is 0.6.5 not formally published?

Apart from Source problem:
* Disttag
  - Please consider to use %?dist tag.
    http://fedoraproject.org/wiki/Packaging/DistTag

* License tag
  - The license tag should be "GPLv2+" (GPL version 2 and any later)
    judging from the contents of the files in the tarball.

* ExcludeArch:
  - mono-core is currently not available on ppc64.

* %configure
----------------------------------------------------------------------
%configure --prefix=%{_usr}
----------------------------------------------------------------------
  - --prefix=%_usr is not needed. Please check what %configure actually
    does by $ rpm --eval %configure.

* optflags
----------------------------------------------------------------------
make RPM_OPT_FLAGS="$RPM_OPT_FLAGS" %{?_smp_mflags}
----------------------------------------------------------------------
  - From build.log I don't think compiling this actually needs
    $RPM_OPT_FLAGS (this is usually used by gcc or g++)

* --delete-original
-----------------------------------------------------------------------
desktop-file-install --vendor="fedora"               \
  --dir=%{buildroot}%{_datadir}/applications    \
  --delete-original    \
  %{name}-gui/resources/%{name}.desktop
-----------------------------------------------------------------------
   - You don't have to delete the desktop file in the source tarball
     (and usually you should not as this breaks rpmbuild -bi --short-circuit)

* empty %post, %postun
  - From $ rpmlint themonospot
-----------------------------------------------------------------------
themonospot.i386: W: empty-%post
themonospot.i386: W: empty-%postun
-----------------------------------------------------------------------
    Please remove these.

* Directory ownership issue
  - Please make it sure that the directories created when installing
    this package are correctly owned by this package.
    For example:
-----------------------------------------------------------------------
[tasaka1 at localhost ~]$ LANG=C rpm -qf /usr/lib/themonospot/themonospot.exe 
themonospot-0.6.5-8.i386
[tasaka1 at localhost ~]$ LANG=C rpm -qf /usr/lib/themonospot/
file /usr/lib/themonospot is not owned by any package
-----------------------------------------------------------------------


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.