[Bug 437397] Review Request: pmtools - power management debugging tools

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pmtools - power management debugging tools


https://bugzilla.redhat.com/show_bug.cgi?id=437397





------- Additional Comments From lkundrak at redhat.com  2008-03-18 11:01 EST -------
1.) %setup -n %{name}-%{version}

%{name}-%{version} is the default value. "%setup -q" would be sufficient (-q is
always mandatory).

2.) * Thu Mar 13 2008 Dave Jones <davej at redhat.com>        20071116

This should have been:
* Thu Mar 13 2008 Dave Jones <davej at redhat.com> - 20071116-1

3.) The package depends on headers from kernel source; Currently they are looked
for in ../include; this is from acpidump Makefile:

KERNEL_INCLUDE := ../include
CFLAGS += -Wall -Wstrict-prototypes -Wdeclaration-after-statement -Os -s
-D_LINUX -DDEFINE_ALTERNATE_TYPES -I$(KERNEL_INCLUDE)

Maybe one solution to this is to depend on kernel-devel and try to guess path to
the includes with something like CPPFLAGS=-I$(ls -d /usr/src/kernels/*/include
|tail -n1). Pay extra attention for the tool not to be dependent on a specific
kernel. It's likely you better know what to do there anyways :)

Another problem in above two lines is that "-Os -s" are not allowed. Patch them
away; and probably take a look at another Makefiles for similar problems.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.