[Bug 437919] Review Request: perl-Catalyst-Controller-BindLex - Stash your lexical goodness

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Catalyst-Controller-BindLex - Stash your lexical goodness


https://bugzilla.redhat.com/show_bug.cgi?id=437919


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2008-03-18 21:51 EST -------
Review:
+ package builds in mock.
Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=521597
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
b498197c02104352563ad20ee4a5d1f9  Catalyst-Controller-BindLex-0.03.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=1, Tests=9,  0 wallclock secs ( 0.29 cusr +  0.02 csys =  0.31 CPU)
+ Package  perl-Catalyst-Controller-BindLex-0.03-1.fc9 =>
  Provides: perl(Catalyst::Controller::BindLex) = 0.03
  Requires: perl(Array::RefElem) perl(Carp) perl(Devel::Caller)
perl(Devel::LexAlias) perl(NEXT) perl(PadWalker) perl(Scalar::Util)
perl(attributes) perl(base) perl(strict) perl(warnings)

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.