[Bug 225243] Merge Review: amanda

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: amanda


https://bugzilla.redhat.com/show_bug.cgi?id=225243





------- Additional Comments From rbrich at redhat.com  2008-03-19 09:11 EST -------
(In reply to comment #4)

Ok, few more points.

> Ah well.  I've updated the pie patch then.  What does -pie buy us these days? 
> Doesn't seem like many programs use it.

The -pie option has some security benefits, I think all Fedora daemons should be
compiled with this. But isn't your new -pie patch missing some configure.in
stuff? I'd rather let it there...

> The problem is that the username listed in .amandahosts is the username on the
> remote machine, not the named on the machine .amandahosts resides on.  We don't
> know that the remote machine has been upgraded or not.  Either way can cause
> problems though, so it's up to you.

Alright. I didn't notice that. But anyway, shouldn't we suppose users will
upgrade all machines at once, rather than having mixed version environment
(which sounds like bad idea)? Moreover, it's already there, why remove it now...

I have also noticed these things:

* The -lib patch, is it really needed? The package compiles just fine without
it. And after patching configure.in with -pie (see above), this gets overriden
by autogen.

* Why did the examples disappear from /usr/share/doc? I though it was good place
for such thing, people may be looking for it there...


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.