[Bug 438105] Review Request: libconcord - Library to talk to Logitech® Harmony® universal remote controls

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libconcord - Library to talk to Logitech® Harmony® universal remote controls


https://bugzilla.redhat.com/show_bug.cgi?id=438105





------- Additional Comments From silfreed at silfreed.net  2008-03-21 13:54 EST -------
(In reply to comment #2)
> 1) This might be GPLv3+ not GPLv2+. See my recent email on concordance-users
> requesting license clarification.

Fixed

> 2) I haven't looked at the SRPM yet, but does it include the "examples"
> directory from CVS?

Doesn't seem to exist.

> 3) The %defattr should probably specify explicit permissions, at least 
that's
> what I was told in my fxload review:
> 
> %defattr(0644,root,root,0755)

I don't see this in the example spec files, or the packaging or review 
guidelines.

> 4) You certainly shouldn't distribute *.a, and I *think* not *.la either, 
even
> in -devel.

Strange that rpmlint didn't pick that up; fixed.

> 5) My comment about making COPYING a %doc to fix the rpmlint warning about 
docs
> was incorrect; I misread that as being re: the main package, not -devel. 
Still,
> if you want to shut rpmlint up, there is a TODO there you could package 
in -devel.
> 

I'll pick up the COPYING file once it's in CVS; I saw your messages on the 
list and it looks like upstream will be renaming licensing.txt soon, as well.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.