[Bug 435578] Review Request: unison227 - File synchronization tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: unison227 - File synchronization tool


https://bugzilla.redhat.com/show_bug.cgi?id=435578


kevin at tummy.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From kevin at tummy.com  2008-03-22 19:13 EST -------
Note that this package/spec is pretty much identical to the unison213 package
that was just recently reviewed.

OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (GPL+)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
4ba0a3e4bf4b4ad0c063f86391371f78  unison-2.27.57.tar.gz
4ba0a3e4bf4b4ad0c063f86391371f78  unison-2.27.57.tar.gz.orig
See below - Package needs ExcludeArch
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package is a GUI app and has a .desktop file

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - No rpmlint output.       
OK - final provides and requires are sane.

SHOULD Items:

OK - Should build in mock.
OK - Should build on all supported archs
OK - Should have dist tag

Issues:   
         
1. Note that you don't need the excludearch for ppc64 on devel/rawhide,
but you currently still do on f7/f8. :(
You might want to file blocker bugs on that to make sure it's
added as soon as ocaml is available for ppc64 f7/f8

I don't see any blockers here, this package is APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.