[Bug 438119] Review Request: perl-Object-Signature - Cryptographically strong objects
bugzilla at redhat.com
bugzilla at redhat.com
Mon Mar 24 12:07:43 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Object-Signature - Cryptographically strong objects
https://bugzilla.redhat.com/show_bug.cgi?id=438119
panemade at gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
------- Additional Comments From panemade at gmail.com 2008-03-24 08:07 EST -------
Review:
+ package builds in mock.
Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=527776
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
b154a57c64ac06bd47b364c924bf3738 Object-Signature-1.05.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
t/01_compile....ok
t/02_main.......ok
t/99_author.....skipped
all skipped: Author tests not required for installation
All tests successful, 1 test skipped.
+ Package perl-Object-Signature-1.05-2.fc9 =>
Provides: perl(Object::Signature) = 1.05
Requires: perl >= 0:5.005 perl(strict) perl(vars)
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the Fedora-package-review
mailing list