[Bug 438024] Review Request: freeimage - Multi-format image decoder library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: freeimage - Multi-format image decoder library


https://bugzilla.redhat.com/show_bug.cgi?id=438024


lemenkov at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From lemenkov at gmail.com  2008-03-25 17:06 EST -------
REVIEW:

+ rpmlint is silent.
+ The package named according to the Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format %{name}.spec.
+ The package meets the Packaging Guidelines.
+ The package licensed with a Fedora approved license and meet the Licensing
Guidelines.
+ The License field in the package spec matches the actual license.
+ The spec file written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package must matches the upstream source.

[petro at Sulaco SOURCES]$ md5sum FreeImage3100.zip*
2e57135e26bb487cc8e13ee7b7e0a595  FreeImage3100.zip
2e57135e26bb487cc8e13ee7b7e0a595  FreeImage3100.zip.1
[petro at Sulaco SOURCES]$ 

+ The package must successfully compiles and builds into binary rpms on ppc
architecture.
+ All build dependencies listed in BuildRequires.
+ Every binary RPM package which stores shared library files (not just symlinks)
in any of the dynamic linker's default paths, must call ldconfig in %post and
%postun. If the package has multiple subpackages with libraries, each subpackage
should also have a %post/%postun section that calls /sbin/ldconfig. An example
of the correct syntax for this is: 

%post -p /sbin/ldconfig

%postun -p /sbin/ldconfig


+ A package owns all directories that it creates.
+ A package does not contain any duplicate files in the %files listing.
+ Permissions on files are set properly.
+ Package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ Each package must consistently use macros, as described in the macros section
of Packaging Guidelines.
+ The package contain code, or permissable content.
+ If a package includes something as %doc, it must not affect the runtime of the
application.
+ Header files are in a -devel package.
+ If a package contains library files with a suffix (e.g. libfoo.so.1.1), then
library files that end in .so (without suffix) must go in a -devel package.
+ In the vast majority of cases, devel packages must require the base package
using a fully versioned dependency: Requires: %{name} = %{version}-%{release} 
+ Packages does NOT contain any .la libtool archives.
+ Packages does not own files or directories already owned by other packages.
+ At the beginning of %install, package run rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ All filenames in rpm packages are valid UTF-8.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.