[Bug 439157] Review Request: perl-Catalyst-View-JSON - JSON view for your Catalyst data

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Catalyst-View-JSON - JSON view for your Catalyst data


https://bugzilla.redhat.com/show_bug.cgi?id=439157


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+




------- Additional Comments From panemade at gmail.com  2008-03-27 08:33 EST -------
Review:
+ package builds in mock.
Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=534049
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
65cfb99bc13dd59f4be3aa6ff1cb718b  Catalyst-View-JSON-0.24.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=2, Tests=41,  0 wallclock secs ( 0.68 cusr +  0.03 csys =  0.71 CPU)
+ Package perl-Catalyst-View-JSON-0.24-1.fc9 =>
  Provides: perl(Catalyst::Helper::View::JSON) perl(Catalyst::View::JSON) = 0.24
  Requires: perl(Catalyst::Exception) perl(Encode) perl(NEXT) perl(base)
perl(strict)

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.