[Bug 439772] Review Request: x11vnc - VNC server for the current X11 session

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request:  x11vnc - VNC server for the current X11 session


https://bugzilla.redhat.com/show_bug.cgi?id=439772


wolfy at nobugconsulting.ro changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?




------- Additional Comments From wolfy at nobugconsulting.ro  2008-03-31 08:37 EST -------
 Needs work:
1. Please use either buildroot or RPM_BUILD_ROOT but not both
2. The Summary line is included twice
3. According to the header of most of the .c files, license is GPLv2+; however
some files under libvncserver include in the comments "see GPL (latest version)"
which might be interpretated into GPLv3 :(
4. I am not sure about the attitude towards using an internal copy of minilzo.
Couldn't x11vnc make use of the existing lzo package ?
5. The ugly part is that x11vnc includes some precompiled java bits and I am
almost certain this is not allowed

Minor
1. Duplicate BuildRequires: xorg-x11-proto-devel (by libXext-devel), zlib-devel
(by openssl-devel)
2. the place for /usr/share/x11vnc/classes/ssl/README is somewhere under doc

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.