[Bug 430377] Review Request: atop - An advanced interactive monitor to view the load on system and process level

bugzilla at redhat.com bugzilla at redhat.com
Mon Mar 31 15:01:40 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: atop - An advanced interactive monitor to view the load on system and process level


https://bugzilla.redhat.com/show_bug.cgi?id=430377





------- Additional Comments From kairoaraujo at gmail.com  2008-03-31 11:01 EST -------
Manuel, thanks for suggestion.
About error in the logic. We can check if pid file exists and has a size greater
than zero.
Example:

if [ -f $PIDFILE ]; then
        PID=`cat $PIDFILE`
        if [ -s $PIDFILE ] && ps -p $PID | grep 'atop$' > /dev/null
        then
                kill -USR1 $PID       
                sleep 3
                kill -TERM $PID
                rm $PIDFILE
                sleep 1
        else
                exit 1
        fi
fi

It's correct? 
	
I thought also to make:
1.) check if file pid exists 
   1.a) if yes: check pid is correct
      1.a.a) if yes: exit 1
      1.a.b) if not: remove pid file and start atop
   1.b) if not: start atop



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list