[Bug 444788] Review Request: guake - Drop-down terminal for GNOME

bugzilla at redhat.com bugzilla at redhat.com
Thu May 1 17:45:55 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: guake - Drop-down terminal for GNOME


https://bugzilla.redhat.com/show_bug.cgi?id=444788





------- Additional Comments From tcallawa at redhat.com  2008-05-01 13:45 EST -------
OK, a few things off the top:

* Don't use Buildprereq, use BuildRequires:
* Don't use %makeinstall, use make DESTDIR=%{buildroot} install
* You need a -devel package for the .a files.
* You need to delete the .la files.
* /usr/share/applications/guake.desktop needs to be installed with
desktop-file-install, see:
http://fedoraproject.org/wiki/Packaging/Guidelines#desktop

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list