[Bug 442276] Review Request: evas - Hardware-accelerated state-aware canvas API for X-Windows

bugzilla at redhat.com bugzilla at redhat.com
Fri May 2 02:48:27 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: evas - Hardware-accelerated state-aware canvas API for X-Windows


https://bugzilla.redhat.com/show_bug.cgi?id=442276


pertusus at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |pertusus at free.fr
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+




------- Additional Comments From pertusus at free.fr  2008-05-01 22:48 EST -------
* rpmlint is silent
* follow guidelines
* free software, license included. License is not really MIT, but if Spot
  considers that it is MIT, let it be MIT
* match upstream
6811e52b0607ce21061a23462a1f9854  evas-0.9.9.042.tar.bz2
* library properly packaged
* %files section right
* doc in devel

I think that it would be better to have 
sed -e 's/$projectname Documentation Generated: $datetime/$projectname
Documentation/'
instead of grep -e, but it is not a blocker. 

Also I would have done that in %prep, but I have no problem if done
in %build.

Terje, is it right with you?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list