[Bug 444792] Review Request: Augeas - library for changing configuration files

bugzilla at redhat.com bugzilla at redhat.com
Fri May 2 08:09:23 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Augeas - library for changing configuration files


https://bugzilla.redhat.com/show_bug.cgi?id=444792





------- Additional Comments From harald at redhat.com  2008-05-02 04:09 EST -------
- SHOULD: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
* OK

- SHOULD: The description and summary sections in the package spec file should
contain translations for supported Non-English languages, if available.
* non available

- SHOULD: The reviewer should test that the package builds in mock. See
MockTricks for details on how to do this.
* OK

- SHOULD: The package should compile and build into binary rpms on all supported
architectures.
* we will see

- SHOULD: The reviewer should test that the package functions as described. A
package should not segfault instead of running, for example.
* OK

- SHOULD: If scriptlets are used, those scriptlets must be sane. This is vague,
and left up to the reviewers judgement to determine sanity.
* OK

- SHOULD: Usually, subpackages other than devel should require the base package
using a fully versioned dependency.
* OK

- SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and
this is usually for development purposes, so should be placed in a -devel pkg. A
reasonable exception is that the main pkg itself is a devel tool not installed
in a user runtime, e.g. gcc or gdb.
* OK

- SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin consider requiring the package which provides the file
instead of the file itself. Please see File Dependencies in the Guidelines for
further information. 
* OK


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list