[Bug 442022] Review Request: wordwarvi - Side-scrolling shoot 'em up '80s style arcade game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wordwarvi - Side-scrolling shoot 'em up '80s style arcade game


https://bugzilla.redhat.com/show_bug.cgi?id=442022





------- Additional Comments From jdieter at gmail.com  2008-05-02 06:38 EST -------
Okay, here's the official review:

MD5SUM:
63c65ef135d69f8248af97f6250fca37  wordwarvi-0.07.tar.gz

Good:
* The package is named according to the Package Naming Guidelines.
* The spec file name matches the base package.
* The package meets the Packaging Guidelines.
* The package is licensed with a Fedora approved license (GPLv2+ for code, CC-BY
and CC-BY-SA for sounds)
* The License field in the package spec file matches the actual license.
* COPYING is included in %doc.
* The spec file is written in American English.
* The spec file for the package is legible.
* The sources used to build the package matches the upstream source.
* The package successfully compiles and builds into binary rpms on i386.
* All build dependencies are listed in BuildRequires.
* The package owns all directories that it creates.
* The package doesn't contain any duplicate files in the %files listing.
* Permissions on files are set properly.
* The package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT.
* The package consistently uses macros.
* The package contains code and permissable content.
* All %doc files do not affect the runtime of the application.
* The package includes a desktop-file-installed %{name}.desktop file.
* At the beginning of %install, the package runs rm -rf $RPM_BUILD_ROOT).
* All filenames in rpm packages are valid UTF-8.
* Source URL is canonical
* Buildroot has all required elements
* All paths begin with macros
* All necessary BuildRequires listed
* All desired features are enabled
* Desktop file has the vendor set to 'fedora'
* Group Tag is from the official list
* Package builds in mock with no errors and one odd warning that has no effect:
  make[1]: warning: jobserver unavailable: using -j1.  Add `+' to parent make 
  rule.

Bad:
Nothing that I could find

rpmlint output:
SRPM: None
RPM:  None

Once a version gets pushed that fixes the segfaults, I'll be happy to approve this.





-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.