[Bug 433925] Review Request: libyahoo2 - Library for the Yahoo! Messenger Protocol

bugzilla at redhat.com bugzilla at redhat.com
Mon May 5 11:00:12 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libyahoo2 - Library for the Yahoo! Messenger Protocol


https://bugzilla.redhat.com/show_bug.cgi?id=433925





------- Additional Comments From lemenkov at gmail.com  2008-05-05 07:00 EST -------
Remarks :

* You should remove *.a and *.la files from devel.
* UTF-8 conversion is wrong (located in rpmlint logs). Proper string will be:

   iconv -f iso8859-1 -t UTF8 AUTHORS > AUTHORS.utf8 && %{__mv} AUTHORS.utf8 AUTHORS
   iconv -f iso8859-1 -t UTF8 NEWS > NEWS.utf8 && %{__mv} NEWS.utf8 NEWS


Other things are looks OK.

So fix these remaining issues and I'll review it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list