[Bug 440597] Review Request: olpcsound - OLPC subset of csound 5

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: olpcsound -  OLPC subset of csound 5


https://bugzilla.redhat.com/show_bug.cgi?id=440597





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-05-07 12:41 EST -------
>From next time please change the EVR (Epoch-Version-Release)
of your spec/srpm every time you modify your spec/srpm to
avoid confusion.

For (2nd) 5.08.91-0:
* License
-------------------------------------------------------
Whole:		LGPLv2+

OOps/random.c			BSD
Opcodes/Loris/lorisgens5.C	GPLv2+
Opcodes/Loris/lorisgens5.h	GPLv2+
Opcodes/Loris/morphdemo.py	GPLv2+
Opcodes/py/pycall-gen.py	GPLv2+
Opcodes/scansyn.c		NON-FREE
Opcodes/scansyn.h		NON-FREE
Opcodes/scansynx.c		NON-FREE
SDIF/sdif-mem.c			MIT
SDIF/sdif-mem.h			MIT
SDIF/sdif.c			MIT
SDIF/sdif.h			MIT
examples/cscore/		GPLv2+
frontends/CsoundX/AudioCode/	NON-FREE
util/*.{c,h}			GPLv2+
util/sortex/			GPLv2+
-------------------------------------------------------
  - To follow http://fedoraproject.org/wiki/Packaging/LicensingGuidelines :
    * libscansyn.so is non-free and cannot be allowed for Fedora
      so please remove this.
    * libstdutil.so is under GPLv2+. So the license tag of olpcsound
      rpm should be "LGPLv2+ and GPLv2+". Also some explanation is
      needed on spec file. Please refer to the section
      "Multiple Licensing Scenarios" of "LicensingGuidelines" wiki.

* Requires
  - Requires for -devel subpackage is wrong for now as:
-------------------------------------------------------
$ rpm -qp --requires olpcsound-devel-5.08.91-0.olpc2.i386.rpm 
libcsnd.so.5.1  
libcsound.so.5.1  
olpcsound=5.08.91-0.olpc2  
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
-------------------------------------------------------
    * This shows that -devel subpackage now Requies the rpm
      named "olpcsound=5.08.91-0.olpc2", not "olpcsound" with
      EVR 5.08.91-0.olpc2.

* Optflags
  - Would you explain why you want "-ffast-math"? This option
    changes (reduces) precision and may render debugging difficult.

* Macros
  - Use macros properly. For example /usr/bin should be %_bindir.
    (by the way why do you want to call scons by full path?)

* Directory ownership issue
  - Again please make it sure all directories created when installing
    a rpm are owned by the rpm.
    * For example, %_libdir/csound is not owned by any package.

* Build working directoryy issue
---------------------------------------------------------
%files -f %{_builddir}/%{name}-%{version}/csound5.lang
---------------------------------------------------------
  - %{_builddir}/%{name}-%{version}/ part is redundant because
    at this stage the working directory is the directory.

* debuginfo rpm issue
  - build.log says:
---------------------------------------------------------
   808  + /usr/lib/rpm/find-debuginfo.sh /builddir/build/BUILD/olpcsound-5.08.91
   809  extracting debug info from
/var/tmp/olpcsound-5.08.91-0.olpc2-root-mockbuild/usr/lib/libcsound.so.5.1
   810  extracting debug info from
/var/tmp/olpcsound-5.08.91-0.olpc2-root-mockbuild/usr/lib/libcsnd.so.5.1
   811  extracting debug info from
/var/tmp/olpcsound-5.08.91-0.olpc2-root-mockbuild/usr/lib/python2.5/site-packages/_csnd.so
   812  0 blocks
---------------------------------------------------------
    This means that these binaries are stripped before %install
    stage ends. Make it sure that these binaries are _not_ stripped
    to create debuginfo rpm properly.

* Documents
  - Please add the following files to %doc.
---------------------------------------------------------
AUTHORS
---------------------------------------------------------
  - The file "INSTALL" is for people who want to build and install
    a software by themselves and is not needed for people who use
    rpm system.

* rpmlint issue
---------------------------------------------------------
olpcsound.i386: W: file-not-utf8 /usr/share/doc/csound/readme-csound5.txt
olpcsound.i386: E: description-line-too-long olpcsound .....
olpcsound.i386: W: no-version-in-last-changelog
---------------------------------------------------------
  - Change the encoding of %_docdir/%name/readme-csound5.txt to UTF-8.
  - Make it sure that all lines in %desctiption should have less than
    80 characters.
  - Add EVR info to %changelog


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.