[Bug 445152] Review Request: yacpi - ncurses based acpi viewer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: yacpi - ncurses based acpi viewer


https://bugzilla.redhat.com/show_bug.cgi?id=445152





------- Additional Comments From bugs.michael at gmx.net  2008-05-07 17:35 EST -------
The patch is dangerous. If it were a larger program, there would
be the risk that DESTDIR finds its way into compiled files.
prefix should become /usr, and only the install paths (in the
install Makefile target) should start with DESTDIR.


> Requires: ncurses

Drop this. There's an automatic dependency on the ncurses
library SONAME added by rpmbuild. Query the binary rpm to see.


%dir %{_defaultdocdir}/yacpi  is missing in %files list.


manual pages are marked as %doc automatically.


CFLAGS still don't include $RPM_OPT_FLAGS.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.