[Bug 445594] Review Request: geeqie - Image browser and viewer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: geeqie - Image browser and viewer


https://bugzilla.redhat.com/show_bug.cgi?id=445594


dan at danny.cz changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review-




------- Additional Comments From dan at danny.cz  2008-05-08 03:09 EST -------
OK	source files match upstream:
	    1feeb974fc5d62b3ad055f11fed224588cf8cd9d  geeqie-1.0alpha1.tar.gz
OK	package meets naming and versioning guidelines.
OK	specfile is properly named, is cleanly written and uses macros consistently.
BAD	dist tag is present.
OK	build root is correct.
OK	license field matches the actual license.
OK	license is open source-compatible (GPLv2). License text included in package.
OK	latest version is being packaged.
OK	BuildRequires are proper.
OK	compiler flags are appropriate.
OK	%clean is present.
OK	package builds in mock (Rawhide/x86_64).
OK	debuginfo package looks complete.
BAD	rpmlint is silent.
BAD	final provides and requires look sane.
N/A	%check is present and all tests pass.
OK	no shared libraries are added to the regular linker search paths.
N/A	owns the directories it creates.
OK	doesn't own any directories it shouldn't.
OK	no duplicates in %files.
OK	file permissions are appropriate.
OK*	scriptlets are present.
OK	code, not content.
OK	documentation is small, so no -docs subpackage is necessary.
OK	%docs are not necessary for the proper functioning of the package.
OK	no headers.
OK	no pkgconfig files.
OK	no libtool .la droppings.
OK	is a GUI app, desktop file is installed

- the disttag is missing from Release
- ChangeLog is not UTF-8 encoded, maybe upstream could do it
geeqie.x86_64: W: file-not-utf8 /usr/share/doc/geeqie-1.0alpha1/ChangeLog
The character encoding of this file is not UTF-8.  Consider converting it
in the specfile for example using iconv(1).
- the scriptlets doesn't follow the guidelines
(http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-de6770dd9867fcd085a73a4700f6bcd0d10294ef)
- the path should be omitted and also the R(post,postun):desktop-file-utils
should not be present
- please add a note (here or into the spec file) about the source and purpose of
the print-pagesize patch


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.