[Bug 227190] Review Request: php-pear-Auth-OpenID - PHP OpenID
bugzilla at redhat.com
bugzilla at redhat.com
Sat May 10 19:37:58 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Auth-OpenID - PHP OpenID
https://bugzilla.redhat.com/show_bug.cgi?id=227190
------- Additional Comments From lemenkov at gmail.com 2008-05-10 15:37 EST -------
ОK, some remarks first.
* According to PearSpecTemplate buildroot must be
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
In any case this is cosmetic issue and may be omitted. I wonder why we still need to explicitly define
BuildRoot?
* According to PearSpecTemplate Requires(post) and Requires(postun) must be
Requires(post): %{__pear}
Requires(postun): %{__pear}
I personally don't know whether this is an issue at all or just a cosmetic
* to make rpmlint happy we need some CRLF-conversions, so we must add BuildRequires: dos2unix and
add to %prep
dos2unix doc/media/*.css
in %files section we must add directories it owns and not only %{pear_phpdir}/* but %{pear_phpdir}/data/Auth_OpenID
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list