[Bug 248431] Review Request: perl-Net-FTPServer - Secure, extensible and configurable Perl FTP server

bugzilla at redhat.com bugzilla at redhat.com
Sun May 11 01:09:15 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Net-FTPServer - Secure, extensible and configurable Perl FTP server
Alias: perl-Net-FTPServer

https://bugzilla.redhat.com/show_bug.cgi?id=248431





------- Additional Comments From steve at silug.org  2008-05-10 21:09 EST -------
(In reply to comment #18)
> Seems to me the license should be GPLv2+.  The copyright notices are there in
the code and documentation and have the usual "either version 2 of the License,
or (at your option) any later version" language.

You're right.  My script that bumps the release converts "GPL" to "GPL+", and I
didn't think to look any closer than that.  That's fixed in -4.

> I don't have a problem with not including the actual server executables, or
with splitting them out, but if the package doesn't actually install a server,
shouldn't the Summary: and %description be adjusted?

Well, it *does* provide the ftp server functionality...

What to put in %description gets really confusing splitting out the server
scripts.  :-)

Anyway, let me know what you think of -4, if you have time:

http://ftp.kspei.com/pub/steve/rpms/perl-Net-FTPServer-1.122-4.src.rpm

> Some weird stuff appears when running the tests:
> 
> error: Tried to add member with zero or undef value for time
>  at /usr/lib/perl5/vendor_perl/5.10.0/Archive/Zip/Member.pm line 487
>         Archive::Zip::Member::_unixToDosTime(0) called at
/usr/lib/perl5/vendor_perl/5.10.0/Archive/Zip/Member.pm line 180
[...]

Reported in the RT ticket mentioned in comment #14.  I haven't had time to dig
any deeper than that yet.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list