[Bug 435835] Review Request: perl-RPC-XML - Set of classes for core data, message and XML handling

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-RPC-XML - Set of classes for core data, message and XML handling
Alias: perl-RPC-XML

https://bugzilla.redhat.com/show_bug.cgi?id=435835





------- Additional Comments From tibbs at math.uh.edu  2008-05-10 23:06 EST -------
Some additional comments:

There's a test suite included; any reason why it's not being run?  Of course,
when you do run it, you'll find out why Chris was telling you about missing
build dependencies, because most of the tests will fail without Test::More and
XML::Parser.  Note that pretty much any reviewer will consider it a blocker to
fail to run the test suite without a good reason.

Also, is there any particular reason why you didn't just use cpanspec to
generate the package?  While there's nothing specifically wrong with rolling
your own by hand, it's a good but more difficult to review since it doesn't look
anything like essentially all of the other Perl packages in the distro.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.