[Bug 443613] Review Request: json-glib - Library for JavaScript Object Notation format

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: json-glib - Library for JavaScript Object Notation format


https://bugzilla.redhat.com/show_bug.cgi?id=443613


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From tibbs at math.uh.edu  2008-05-11 14:25 EST -------
It looks like 0.6.0 has recently come out; did you want to update or stick with
0.4.0?  Anyway, here's a review of 0.4.0; if you think 0.6.0 is significantly
different then drop an updated package and I'll review it instead.

The test suite is odd.  It's there, but "make check" doesn't actually run any
tests.  The built tests are just executables which produce some output and exit
0.  I guess it doesn't hurt to call it just in case; perhaps a test suite will
appear one day.

/usr/share/gtk-doc/html seems to be unowned in the -devel package.  I guess a
dependency on gtk-doc is needed, although several other packages seem to own
that directory.

I note that the library calls itself libjson-glib-1.0; I wonder if that's an
issue given that it's not actually 1.0 yet.

* source files match upstream:
   f0ac5c90505fa187cff7409a8d660d8ac8ec867f3abedbe7e42944268632baa9  
   json-glib-0.4.0.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
? latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
* rpmlint is silent.
? final provides and requires are sane:
  json-glib-0.4.0-1.fc9.x86_64.rpm
   libjson-glib-1.0.so.0()(64bit)
   json-glib = 0.4.0-1.fc9
  =
   /sbin/ldconfig
   libglib-2.0.so.0()(64bit)
   libgobject-2.0.so.0()(64bit)
   libjson-glib-1.0.so.0()(64bit)

  json-glib-devel-0.4.0-1.fc9.x86_64.rpm
   json-glib-devel = 0.4.0-1.fc9
  =
   glib2-devel
   json-glib = 0.4.0-1.fc9
   libjson-glib-1.0.so.0()(64bit)
   pkgconfig
?  perhaps needs gtk-doc

* %check is present, although it doesn't actually do anything.
* shared libraries present; ldconfig is called properly.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets OK (ldconfig)
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* headers are in the -devel package.
* pkgconfig files are in the -devel package, with pkgconfig dependency.
* no static libraries.
* no libtool .la files.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.