[Bug 446651] Review Request: rvm - RVM library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: rvm - RVM library


https://bugzilla.redhat.com/show_bug.cgi?id=446651





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-05-15 14:43 EST -------
For 1.15-1:

* License:
----------------------------------------------------
include/coda_mmap_anon.h	GPLv2
rvm/rvm_map.c			#include "coda_mmap_anon.h"
   792  DEBUG:  gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../include -DRVM_USELWP -O2
-g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic
-fasynchronous-unwind-tables -MT librvmlwp_la-rvm_map.lo -MD -MP -MF
.deps/librvmlwp_la-rvm_map.Tpo -c rvm_map.c  -fPIC -DPIC -o
.libs/librvmlwp_la-rvm_map.o
   828  DEBUG: gcc -shared  .libs/librvmlwp_la-rvm_init.o
.libs/librvmlwp_la-rvm_map.o .libs/librvmlwp_la-rvm_unmap.o
.libs/librvmlwp_la-rvm_tran
s.o .libs/librvmlwp_la-rvm_logstatus.o .libs/librvmlwp_la-rvm_logflush.o
.libs/librvmlwp_la-rvm_logrecovr.o .libs/librvmlwp_la-rvm_utils.o .libs/
librvmlwp_la-rvm_io.o .libs/librvmlwp_la-rvm_status.o
.libs/librvmlwp_la-rvm_debug.o .libs/librvmlwp_la-rvm_printers.o  -llwp  -m32
-march=i386 -
mtune=generic -Wl,-soname -Wl,librvmlwp.so.1 -o .libs/librvmlwp.so.1.2.2

seg/rvm_segutil.c		#include "coda_mmap_anon.h"
   846  DEBUG:  gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../include -O2 -g -pipe -Wall
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4
-m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables -MT
libseglwp_la-rvm_segutil.lo -MD -MP -MF .deps/libseglwp_la-rvm_segutil.Tpo -c
rvm_segutil.c  -fPIC -DPIC -o .libs/libseglwp_la-rvm_segutil.o
   857  DEBUG: gcc -shared  .libs/libseglwp_la-rvm_segutil.o
.libs/libseglwp_la-rvm_loadseg.o .libs/libseglwp_la-rvm_createseg.o .libs/libseglwp_
la-rvm_releaseseg.o  ../rvm/.libs/librvmlwp.so  -m32 -march=i386 -mtune=generic
-Wl,-soname -Wl,libseglwp.so.1 -o .libs/libseglwp.so.1.2.2

   900  DEBUG: gcc -shared  .libs/librdslwp_la-rds_coalesce.o
.libs/librdslwp_la-rds_free.o .libs/librdslwp_la-rds_init.o
.libs/librdslwp_la-rds_malloc.o .libs/librdslwp_la-rds_prealloc.o
.libs/librdslwp_la-rds_split.o .libs/librdslwp_la-rds_stats.o
.libs/librdslwp_la-rds_start.o .libs/librdslwp_la-rds_util.o
.libs/librdslwp_la-rds_zap.o .libs/librdslwp_la-rds_maxblock.o 
../seg/.libs/libseglwp.so ../rvm/.libs/librvmlwp.so -llwp  -m32 -march=i386
-mtune=generic -Wl,-soname -Wl,librdslwp.so.1 -o .libs/librdslwp.so.1.2.2
----------------------------------------------------
  - All GPLv2!! :(

* Dependency for devel package
----------------------------------------------------
[tasaka1 at localhost ~]$ LANG=C pkg-config --libs rvmlwp
Package lwp was not found in the pkg-config search path.
Perhaps you should add the directory containing `lwp.pc'
to the PKG_CONFIG_PATH environment variable
Package 'lwp', required by 'Recoverable Virtual Memory (lwp build)', not found
----------------------------------------------------
  - This means that lwp-devel should be in the Requires
    of rvm-devel.

* rpath hack
----------------------------------------------------
# Don't use rpath!
sed -i 's|^hardcode_libdir_flag_spec=.*|hardcode_libdir_flag_spec=""|g' libtool
sed -i 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' libtool
# work around linking failures because of the disabling of rpath above
export LD_LIBRARY_PATH=`pwd`/rvm/.libs:`pwd`/seg/.libs
----------------------------------------------------
  - Umm.. are there any better hack than this way? Especially
    adding the need of LD_LIBRARY_PATH like above is IMO
    not good, just creating a broken libtool.

    In such case, I usually
    - add /usr/lib /lib64 to sys_lib_search_path_spec in 
      configure (as libtool is created from configure)
    
      Actually the diff of %_bindir/libtool between i386 and x86_64
      shows this.

    - Or simply "make LIBTOOL=%_bindir/libtool" or cp %_bindir/libtool
      to working directory (BR: libtool is needed).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.