[Bug 446407] Review Request: unique - library for writing single instance applications

Fri May 16 07:38:07 UTC 2008

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: unique - library for writing single instance applications

https://bugzilla.redhat.com/show_bug.cgi?id=446407

dan at danny.cz changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

------- Additional Comments From dan at danny.cz  2008-05-16 03:38 EST -------
I have done a rebuild on Rawhide without BR: libtool and it works, so please
remove it when uploading the spec into the CVS.

OK	source files match upstream:
	    5980013ab57c5391f63c9171d39c325f15584838  unique-0.9.4.tar.gz
OK	package meets naming and versioning guidelines.
OK	specfile is properly named, is cleanly written and uses macros consistently.
OK	dist tag is present.
OK	build root is correct.
OK	license field matches the actual license.
OK	license is open source-compatible (LGPLv2+). License text included in package.
OK	latest version is being packaged.
OK*	BuildRequires are proper.
OK	compiler flags are appropriate.
OK	%clean is present.
OK	package builds in mock (Rawhide/x86_64).
OK	debuginfo package looks complete.
OK	rpmlint is silent.
OK	final provides and requires look sane.
N/A	%check is present and all tests pass.
OK	shared libraries are added to the regular linker search paths, ldconfig is
called.
OK	owns the directories it creates.
OK	doesn't own any directories it shouldn't.
OK	no duplicates in %files.
OK	file permissions are appropriate.
OK	correct scriptlets present.
OK	code, not content.
OK	documentation is small, so no -docs subpackage is necessary.
OK	%docs are not necessary for the proper functioning of the package.
OK	headers in -devel.
OK	pkgconfig file in -devel, dependency on pkgconfig exists.
OK	no libtool .la droppings.
OK	not a GUI app.

this package is APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.