[Bug 429006] Review Request: gnome-subtitles - Subtitle editor for Gnome

bugzilla at redhat.com bugzilla at redhat.com
Sun May 18 23:41:34 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-subtitles - Subtitle editor for Gnome


https://bugzilla.redhat.com/show_bug.cgi?id=429006





------- Additional Comments From akahl at iconmobile.com  2008-05-18 19:41 EST -------
@Matthias:
Thank you for the help :) I've tried to reach you directly via email before
several times but never got a reply.

@Julian:

Package Review (pt. 2)
=====================
Only re-checking rpmlint, errors from last review and diff between old and new
spec.

* rpmlint output:
  gnome-subtitles.x86_64: W: non-conffile-in-etc
/etc/gconf/schemas/gnome-subtitles.schemas
  OK, see last review
-------------------------------------------------------------------------------
* The sources used to build the package matches the upstream source:
SHA1 14fe9eabf4288fc23072988f4423b5f447642352  gnome-subtitles-0.8.tar.gz
* Builds locally on dist-f9 x86_64
* BuildRequires look sane
* Builds on all Fedora supported architectures but ppc64 (excluded)
* Package owns all directories it creates
* No duplicates in %files
* File permissions are sane

Mono-specific Checks
====================
* Not distributing .DLLs from other projects


As soon as sublib is in and its bug closed, I'll give you approval.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list